-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Justfile #185
Justfile #185
Conversation
ci: test lint jpi | ||
|
||
# Build the local Antora documentation | ||
docs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried running this locally:
Unable to find image 'docker.pkg.github.com/boozallen/sdp-docs/builder:latest' locally
docker: Error response from daemon: Head https://docker.pkg.github.com/v2/boozallen/sdp-docs/builder/manifests/latest: no basic auth credentials.
I have ~/.git-credentials for github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker login docker.pkg.github.com
and then use your GH user/pat
we could try to automate that part too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm did not work
carlosokieffe@C02D80XNMD6V templating-engine-plugin % docker login docker.pkg.github.com
Username: cokieffebah
Password:
Login Succeeded
carlosokieffe@C02D80XNMD6V templating-engine-plugin %
carlosokieffe@C02D80XNMD6V templating-engine-plugin % git pull docker.pkg.github.com/boozallen/sdp-docs/builder:latest
fatal: 'docker.pkg.github.com/boozallen/sdp-docs/builder:latest' does not appear to be a git repository
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
carlosokieffe@C02D80XNMD6V templating-engine-plugin % just docs
docker run -it --rm -v ~/.git-credentials:/home/antora/.git-credentials -v $(pwd):/app -w /app docker.pkg.github.com/boozallen/sdp-docs/builder generate --generator booz-allen-site-generator --to-dir docs/html docs/antora-playbook-local.yml
Unable to find image 'docker.pkg.github.com/boozallen/sdp-docs/builder:latest' locally
docker: Error response from daemon: unauthorized: Your request could not be authenticated by the GitHub Packages service. Please ensure your access token is valid and has the appropriate scopes configured.
See 'docker run --help'.
error: Recipe `docs` failed on line 47 with exit code 125
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved the PR. just noting the issues with the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you accidentally ran git pull
instead of docker pull
.
when you authenticated, did you use your password or a PAT?
if a PAT, it would need to have the read:packages
scope
PR Details
Switch to using Just instead of Make
Description
Makefile
in favor of aJustfile
CONTRIBUTING.adoc
which outlines how to use theJustfile
CONTRIBUTING.adoc
so it can be rendered in the Antora docsHow Has This Been Tested
Lots of manual testing. We should continuously update this Justfile to streamline our processes wherever possible.